[PR1] refactoring :apps build and adding spark3.5/iceberg1.5 artifact #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbb330
force-pushed
the
main
branch
7 times, most recently
from
7dcde77
to
3e7e046
Compare
cbb330
changed the title
|
Is this ready for review? |
@autumnust waiting on #221 to merge so i can rebase. this PR is forked from that. if you want you can compare the commit delta here: https://github.com/linkedin/openhouse/pull/255/files/770a6d0497b9af7b1bedb876cbf639b71b3a9822..94c5100d5aa780a373ee5d0e14394ecdcec2f561 |
cbb330
force-pushed
the
main
branch
2 times, most recently
from
81e11a0
to
ab39faa
Compare
cbb330
changed the title
jiang95-dev
requested changes
Nov 25, 2024
buildSrc/src/main/groovy/openhouse.apps-spark-conventions.gradle
Outdated
Show resolved
Hide resolved
autumnust
requested changes
Nov 26, 2024
sumedhsakdeo
changed the title
teamurko
reviewed
Dec 2, 2024
jiang95-dev
approved these changes
Dec 2, 2024
teamurko
approved these changes
Dec 3, 2024
autumnust
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is Part 1 of 2 for enabling compaction based MoR.
problem: enabling Merge-on-Read for customer tables requires the ability to compact delete files. Compacting delete files is supported in spark3.1/iceberg1.2 but requires us to test it. We cannot test it, because creating delete files is not supported in spark3.1 (only compacting existing ones).
solution: we add spark3.5/iceberg1.5 compaction application, which extends the existing compaction test suite. in a follow up PR, we will add tests which create delete files and compacts the delete files under the latest versions.
Changes
Testing Done
all tests running on spark3.1 and spark3.5:
correct spark version resolutions for test runtime:
correct spark version resolutions for runtime:
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.